[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Jens, please try to get more peer review

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 29 May 2008 11:19:48 +0200

Hey Jens,

you have made a few commits outside the area that you have
been nominated a partial committer for (German translations).

This is great, I am very happy to see you contributing to
Subversion even more than by translating -- which is
already quite some job! I've tried updating the German
translation before, and it took me ages, so I was very glad
when you sent another update in time for 1.5 :)

But I think that some of your commits made outside the German
translation should have gotten more peer review. Specifically,
you have never put an 'Approved-by:' line in any of your commits
outside of your area (r31457, r31459, r31460, r31461, r31484,
r31491, and r31496). Why not?

I know that some of the changes you made fall under the 'obvious
fix' rule, but please keep in mind that the definition of 'obvious fix'
varies from person to person. When I was a partial committer,
I always thought: "Mmmh... I *think* I have an obvious fix here,
but let's just ask someone else anyway to see if others think I'm right."
Going to IRC and asking other developers for their judgement
takes about 5 minutes (if someone is there to respond, which is
usually the case at least during US working hours).

Another note on 'Approved-by': I think it helped me a lot to
always have my changes reviewed while I was a partial committer
committing outside my area. In fact, I still don't trust myself
enough to always commit non-trivial changes without getting feedback
from others first. So I still post many of my patches to the list and
wait for feedback for a few days before committing them. I often get
feedback, and so far, whenever I got feedback it has always improved
the end result significantly.
I think peer review is very essential in collaborative development.
And at the very least, it helps me a lot to improve my own skills
and judgement.

Please try to get your commits outside the German translation
approved in the future.


  • application/pgp-signature attachment: stored
Received on 2008-05-29 11:17:37 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.