[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] 1.5.x branch: python/cmdline

From: Alexander Sinyushkin <Alexander.Sinyushkin_at_svnkit.com>
Date: Thu, 29 May 2008 15:13:42 +0700

Hello!

Attached is a patch that fixes number of minor issues in Subversion
python tests suite. Patch is against 1.5.x branch.

Explanation:

main.py patch

Recently we started to use client/server approach for running Subversion
python tests suite against SVNKit Subversion library. We use server that
accepts Subversion commands through the TCP/IP socket and client which
is a bash script - it reads parameters, stdin, certain environment
variables and then sends everything to the server.

To send data to the server we use netcat or, alternatively, bash
/dev/tcp/host/port device. In both case complete stdin have to be read
before sending data to the server. However, main.py doesn't close stdin
of the launched process before launching another process (in particular
when running svnadmin dump repos1 | svnadmin load repos2 commands). As a
result our tests were entering a deadlock. Suggested patch doesn't
change anything in tests behavior with native Subversion - it just
closes stdin of the launched process as soon as no more data is about to
be sent to the process stdin.

Another modification included into this patch is setting
SVN_CURRENT_TEST environment variable before running certain test. This
allows us to track what test is currently running when the whole test
suite is launched (i.e. "./copy.py" without specifying exact test number
to run).

And at last, made svndumpfilter_binary point to a jsvndumpfilter binary
if --use-jsvn is specified.

You will make our life much easier if you include this contribution to
your repository :) Thank you in advance!

----
Alexander Sinyushkin,
TMate Software,
http://svnkit.com/ - Java [Sub]Versioning Library!


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-05-29 10:14:20 CEST

This is an archived mail posted to the Subversion Dev mailing list.