[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] ISSUE #3193 Fix peg revision parsing for CLI repository root relative urls.

From: Folker Schamel <schamel23_at_spinor.com>
Date: Wed, 28 May 2008 22:37:57 +0200

Karl Fogel wrote:
> Folker Schamel <schamel23_at_spinor.com> writes:
>>> In any case, we're not going to go and add apr_pstrdup's around every
>>> single string constant in Subversion!
>> Its not about every constant string, its just about constant strings
>> directly returned by API functions.
>> Alternatively, you might just add one global sentence to the API spec
>> saying basically that the lifetime of returned strings is not only
>> limited by pool lifetimes, but also by library lifetimes.
> We've been returning constant strings for about eight years now, and
> we've never heard a bug report about it. Given that, I don't think we
> should clutter up our API documentation by mentioning this concern.
> -Karl

Wasn't meant offensive and I don't want to demand anything.
I just noticed that aspect and wanted to mentioned it briefly
in case you are not aware.
Obviously you are aware of it and deliberately do it that way,
so everything is fine.
Sorry for the noise.


To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-28 22:38:24 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.