[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r27729 breaks API of svn_ra_get_log2

From: Martin von Gagern <Martin.vGagern_at_gmx.net>
Date: Tue, 27 May 2008 18:35:24 +0200

David Glasser wrote:
>>> I haven't seen this in real life yet, but I believe r27737 introduced an
>>> inconsistency with the API spec.
>>
> Actually, looks like it was r27729

The subject was right all along, but while writing the body I must have
copied from the wrong tab. Sorry for any confusion I caused.

> I think putting the whole loop in an if would be more clear.

Slightly better for performance as well, but I guess that doesn't count
much here.

By now I encountered this in real live as well, and the first suggested
fix works as expected. https://bugs.launchpad.net/bzr-svn/+bug/234010

Although I'm an outsider, I'd say the risk of breaking anything due to
this fix is considerably lower than breakage due to the bug, so I'd vote
to place it into 1.5.0.

Looking at the email that just arrived, it seems to be decided that way.

Greetings,
  Martin von Gagern

Received on 2008-05-27 18:36:08 CEST

This is an archived mail posted to the Subversion Dev mailing list.