[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r27729 breaks API of svn_ra_get_log2

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Tue, 27 May 2008 12:30:01 -0400

David Glasser wrote:
>> Index: subversion/libsvn_ra/ra_loader.c
>> ===================================================================
>> --- subversion/libsvn_ra/ra_loader.c (revision 31465)
>> +++ subversion/libsvn_ra/ra_loader.c (working copy)
>> @@ -1023,7 +1023,7 @@
>> apr_pool_t *pool)
>> {
>> int i;
>> - for (i = 0; i < paths->nelts; i++)
>> + for (i = 0; paths && (i < paths->nelts); i++)
>> {
>> const char *path = APR_ARRAY_IDX(paths, i, const char *);
>> assert(*path != '/');
>
> I think putting the whole loop in an if would be more clear.

I agree, and did so when I committed.

> svn_ra_get_log needs the same change; maybe more?

I did *not*, however, catch this, so it took me two commits to fully fix
this (r31468 and r31470). I made a quick scan of the other APIs, and I
think they're fine.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2008-05-27 18:30:17 CEST

This is an archived mail posted to the Subversion Dev mailing list.