[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r27729 breaks API of svn_ra_get_log2

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Tue, 27 May 2008 10:53:18 -0400

"C. Michael Pilato" <cmpilato_at_collab.net> writes:
>> Do you agree this is a bug?
>
> Yes. (An oversight on my part.)
>
>> Would you like to see this in the issue tracker?
>
> Not if the following patch fixes it.
>
> Index: subversion/libsvn_ra/ra_loader.c
> ===================================================================
> --- subversion/libsvn_ra/ra_loader.c (revision 31465)
> +++ subversion/libsvn_ra/ra_loader.c (working copy)
> @@ -1023,7 +1023,7 @@
> apr_pool_t *pool)
> {
> int i;
> - for (i = 0; i < paths->nelts; i++)
> + for (i = 0; paths && (i < paths->nelts); i++)
> {
> const char *path = APR_ARRAY_IDX(paths, i, const char *);
> assert(*path != '/');

And assuming that this fixes it, I think this can go into an RC8 under
the "obvious fix" doctrine and not require a full resoak (the one-week
final resoak would be enough).

Or should it wait until 1.5.1? But I worry that this is a commonly-used
API and that a bug in it will bite a non-trivial number of people who
write wrapper applications.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-27 16:53:33 CEST

This is an archived mail posted to the Subversion Dev mailing list.