[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] ISSUE #3193 Fix peg revision parsing for CLI repository root relative urls.

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Tue, 27 May 2008 00:31:51 -0400

"Troy Curtis Jr" <troycurtisjr_at_gmail.com> writes:
>> No need to strdup "" into a pool. Just assign "" directly; the static
>> storage won't hurt anyone, will it?
>
> Ok, I'm still trying to get used to all this pool based things. The
> static storage is OK here because the string is never explicitly freed
> by the caller, just the pool is freed at some point in the future. Do
> I understand that correctly?

That's correct. No one's going to be calling free() on anything, so
it's safe to return pointers to static strings (though not when they're
going to be modified in place, of course).

> I have accepted it, and I do believe that this commit fixes it. Is
> the standard procedure to have someone else verify it and close it?
> Like the reporter?

Nope, you can just close it as FIXED.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-27 06:32:10 CEST

This is an archived mail posted to the Subversion Dev mailing list.