[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31427 - trunk/subversion/libsvn_auth_kwallet

From: David Glasser <glasser_at_davidglasser.net>
Date: Mon, 26 May 2008 13:20:01 -0700

On Mon, May 26, 2008 at 12:58 PM, Karl Fogel <kfogel_at_red-bean.com> wrote:
> "David Glasser" <glasser_at_davidglasser.net> writes:
>> On Sat, May 24, 2008 at 10:07 AM, <arfrever_at_tigris.org> wrote:
>>> --- trunk/subversion/libsvn_auth_kwallet/kwallet.cpp (r31426)
>>> +++ trunk/subversion/libsvn_auth_kwallet/kwallet.cpp (r31427)
>>> @@ -104,8 +104,8 @@ kwallet_password_get(const char **passwo
>>> }
>>> }
>>> }
>>> - KWallet::Wallet::disconnectApplication(wallet_name,
>>> - QString::fromUtf8("Subversion"));
>>> +// KWallet::Wallet::disconnectApplication(wallet_name,
>>> +// QString::fromUtf8("Subversion"));
>>
>> Ugh, commenting out code is bad. Was this just a temporary tweak?
>
> Also, when we do comment, we use C-style, not C++- :-).

Admittedly this is a C++ file.

--dave

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-26 22:20:10 CEST

This is an archived mail posted to the Subversion Dev mailing list.