[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31427 - trunk/subversion/libsvn_auth_kwallet

From: David Glasser <glasser_at_davidglasser.net>
Date: Mon, 26 May 2008 09:19:10 -0700

On Sat, May 24, 2008 at 10:07 AM, <arfrever_at_tigris.org> wrote:
> Author: arfrever
> Date: Sat May 24 10:07:45 2008
> New Revision: 31427
>
> Log:
> * subversion/libsvn_auth_kwallet/kwallet.cpp
> (kwallet_password_get, kwallet_password_set): Don't disconnect Subversion
> from KWallet because disconnection works incorrectly in KDE 4.0.4.
>
> Modified:
> trunk/subversion/libsvn_auth_kwallet/kwallet.cpp
>
> Modified: trunk/subversion/libsvn_auth_kwallet/kwallet.cpp
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_auth_kwallet/kwallet.cpp?pathrev=31427&r1=31426&r2=31427
> ==============================================================================
> --- trunk/subversion/libsvn_auth_kwallet/kwallet.cpp Sat May 24 09:27:55 2008 (r31426)
> +++ trunk/subversion/libsvn_auth_kwallet/kwallet.cpp Sat May 24 10:07:45 2008 (r31427)
> @@ -104,8 +104,8 @@ kwallet_password_get(const char **passwo
> }
> }
> }
> - KWallet::Wallet::disconnectApplication(wallet_name,
> - QString::fromUtf8("Subversion"));
> +// KWallet::Wallet::disconnectApplication(wallet_name,
> +// QString::fromUtf8("Subversion"));

Ugh, commenting out code is bad. Was this just a temporary tweak?

--dave

> return ret;
> }
>
> @@ -167,8 +167,8 @@ kwallet_password_set(apr_hash_t *creds,
> }
> }
> }
> - KWallet::Wallet::disconnectApplication(wallet_name,
> - QString::fromUtf8("Subversion"));
> +// KWallet::Wallet::disconnectApplication(wallet_name,
> +// QString::fromUtf8("Subversion"));
> return ret;
> }
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: svn-help_at_subversion.tigris.org
>
>

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-26 18:19:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.