Karl Fogel wrote on Sun, 25 May 2008 at 22:30 -0400:
> Arfrever Frehtes Taifersar Arahesis <arfrever.fta_at_gmail.com> writes:
> >> Log:
> >> Implement the 'password-stores' config option.
> >>
> >> --- trunk/subversion/libsvn_subr/cmdline.c (r31427)
> >> +++ trunk/subversion/libsvn_subr/cmdline.c (r31428)
> >> @@ -435,17 +435,45 @@ svn_cmdline_setup_auth_baton(svn_auth_ba
> >>
> >> [...]
> >>
> >> #ifdef SVN_HAVE_KWALLET
> >> - if (get_auth_simple_provider(&provider, "kwallet", pool))
> >> - {
> >> - APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> >> + if (apr_strnatcmp(password_store, "kwallet") == 0)
> >> + {
> >> + if (get_auth_simple_provider(&provider, "kwallet", pool))
> >> + {
> >> + APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> >> + }
> >> + continue;
> >> + }
> >> +#endif
> >> + /* TODO: Error. */
Don't you need to also allow the case where password_store == ""?
> >
> > Which error code should be used for invalid value of DAV-unrelated
> > configuration option?
>
Nothing? It will fall back to plaintext passwords and get a warning
there...
> SVN_ERR_AUTHN_NO_PROVIDER ?
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-26 08:06:45 CEST