[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: issue #1796

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Sun, 25 May 2008 21:25:37 -0400

Neels Janosch Hofmeyr <neels_at_elego.de> writes:
> Checking for LF is easy. For UTF-8, there is this function in
> subversion/libsvn_subr/utf.c called check_utf8(..), which I gather I
> cannot access from libsvn_repos unless it is made public in
> subversion/include/svn_utf.h
>
> So, I want to rename check_utf8 to svn_utf_check_utf8, put a "@since New
> in 1.6" tag on the public doc string, publish it in include/svn_utf.h,
> adjust all callers and use it in libsvn_repos/fs-wrap.c, in function
> validate_prop(..).
>
> Am I on the right track here? :)

You're on the right track, but you don't have to make the function
public. Subversion has an intermediate level of inter-library privacy,
to allow a symbol to be shared among Subversion's modules without
publishing that symbol to the world. See here:

   http://svn.collab.net/repos/svn/trunk/subversion/include/private

Does that help?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-26 03:25:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.