[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] ISSUE #3193 Fix peg revision parsing for CLI repository root relative urls.

From: Troy Curtis Jr <troycurtisjr_at_gmail.com>
Date: Sun, 25 May 2008 14:35:24 -0500

Here is my revised patch, incorporating various suggestions/comments

[[[
Fix peg revision support for repository root urls to address issue
#3193.

Move the duplicated peg revision parsing functionality from
svn_client_args_to_target_array(), svn_opt_args_to_target_array3(),
and
svn_opt_parse_path() into a new function
svn_opt__split_arg_at_peg_revision().

* subversion/libsvn_subr/opt.c
  (svn_opt__split_arg_at_peg_revision): New function.
  (svn_opt_parse_path,
   svn_opt_args_to_target_array3): Replace in-line peg revision
parsing with
   the new svn_opt__split_arg_at_peg_revision() function.

* subversion/include/private/svn_opt_private.h
  (svn_opt__split_arg_at_peg_revision): New function prototype.

* subversion/libsvn_client/cmdline.c
  (svn_opt_args_to_target_array3): Replace in-line peg revision
parsing with
   the new svn_opt__split_arg_at_peg_revision() function.

* subversion/tests/cmdline/basic_tests.py
  (basic_relative_url_with_peg_revisions): New test function.
  (test_list): Call the new test function.
]]]

-- 
"Beware of spyware. If you can, use the Firefox browser." - USA Today
Download now at http://getfirefox.com
Registered Linux User #354814 ( http://counter.li.org/)


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org

Received on 2008-05-25 21:35:39 CEST

This is an archived mail posted to the Subversion Dev mailing list.