[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: issue #1796

From: Branko ─îibej <brane_at_xbc.nu>
Date: Sun, 25 May 2008 14:27:20 +0200

Stefan Sperling wrote:
> On Sun, May 25, 2008 at 12:21:19AM +0200, Neels Janosch Hofmeyr wrote:
>
>> So, we've got the subversion server (libsvn_repos) which accepts
>> any garbage written in commit log messages. It doesn't enforce
>> consistent line endings, and, AFAIK, neither does it check whether the
>> log is valid UTF8, which it should be according to spec.
>>
>
>
>> So, I would like to check incoming log messages (or even all incoming
>> svn: prop values, depending on whether this is nice) for their
>> compliance with UTF-8 and LF line ending style.
>>
>
> Why not try to normalise the log message on the server?
>
> Couldn't we run the log message through a function like
> svn_utf_stringbuf_to_utf8() and raise an error if that function fails?
>

Nope, that function expects the original message to be in the local
encoding, which clearly violates the API requirements; it would only
"work" on servers whose local encoding is already UTF-8 -- but in that
case, IIRC, the function is a no-op anyway.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-25 14:28:00 CEST

This is an archived mail posted to the Subversion Dev mailing list.