[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Possible bad (incorrect) JavaHL test inserted into 1.5.x

From: Mark Phippard <markphip_at_gmail.com>
Date: Sat, 24 May 2008 19:45:10 -0400

On Sat, May 24, 2008 at 7:42 PM, Blair Zajac <blair_at_orcaware.com> wrote:
> Mark Phippard wrote:
>> On Sat, May 24, 2008 at 7:21 PM, Blair Zajac <blair_at_orcaware.com> wrote:
>>>> Since the revprops are coming in a Map, it makes sense that they are
>>>> consistently all the same type of object, in which case it needs to be
>>>> a String. I also agree with Hyrum that it makes sense to do as much
>>>> logic in Java as we can.
>>> Not when it adds to the overhead of understanding what the code does.
>> What are you referring to? The revprop Map? I think Hyrum did a
>> pretty good job explaining why it should be the way it is. I also do
>> not think it makes sense for every object in the Map to be a string,
>> except for the svn:date which users are supposed to know is some other
>> kind of object. It also precludes us from ever using generics.
> True.
>> Are Subversion dates always in UTC? That is what I think the problem is.
> Well, I haven't look too closely, The issue is the time conversion issue
> you're running into and using the new parsing code. And the map can still
> be Map<String,String>, just putting the string to microseconds back in the C
> code instead of the Java code.

The problem with that is that you either have an svn:date property
that does not look like a date, or you add a non-existant revision
property to the Map that people need to know to treat special or
ignore. It seems like something we only need to get right once. Plus
if you use the new API this is actually more performant as the date
does not have to be parsed until and unless you have code that wants
to parse it.

Mark Phippard
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-25 01:45:23 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.