[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Ruby bindings test failure on 1.5.x branch

From: Mark Phippard <markphip_at_gmail.com>
Date: Fri, 23 May 2008 15:35:05 -0400

On Fri, May 23, 2008 at 11:39 AM, Mark Phippard <markphip_at_gmail.com> wrote:
> On Fri, May 23, 2008 at 11:33 AM, Bert Huijben <bert_at_vmoo.com> wrote:
>>> > But I don't know about a need of notification API
>>> > incompatibility between trunk and 1.5.x.
>>
>> This test probably fails on the notification changes in r31211. Before that
>> revision the notify handler received commit paths which weren't valid in all
>> cases (not-relative and not-absolute and it must be one or the other to be
>> correct).
>>
>> Starting in r31211 the handler receives the whole path and a path_prefix of
>> the commit root. (From those parts the old displayed path can be
>> calculated.. but that display path is not always valid)
>>
>> See subversion/svn/notify.c for some example code on how to translate the
>> path.
>>
>> (Summary: If path prefix is non-null and equals the start of path, then
>> strip prefix from path).
>>
>>
>> Note: r31211 is not backported to 1.5.x.
>
> So this doesn't really explain why the test would fail on the branch.
> Did a test that only belongs on trunk get backported to the branch?

It looks like this test was added to Ruby in r31348 (after your
change) and backported to 1.5.x in r31356. So I propose that we just
commit the 1-line patch that Kouhei submitted directly to the 1.5.x
branch as the resolution for this.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-23 21:35:16 CEST

This is an archived mail posted to the Subversion Dev mailing list.