[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: issue #1796

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Thu, 22 May 2008 21:30:27 -0400

Neels Janosch Hofmeyr <neels_at_elego.de> writes:
> I am busy on a fix for issue
> #1796: defective or malicious client can corrupt repository log messages
> and would like to validate that property values are good UTF8.
>
> There is a private function in subversion/libsvn_subr/utf.c:
>
> check_utf8(const char *data, apr_size_t len, apr_pool_t *pool)
>
> All of the *public* methods in subversion/include/svn_utf.h produce new
> data. I just need a validation.
>
> Is it ok to publish check_utf8 in subversion/include/svn_utf.h? Is that
> "just another fix" or does it have release implications? And how would I
> go about it; it would probably have to be called svn_utf_check_utf8... ?

You're saying you need a public function for confirming that a string is
valid utf8? Sure, you can just move the private function to public,
giving it the "svn_utf_" prefix and changing all callers. See
http://subversion.tigris.org/hacking.html#other-conventions the formal
conventions. You'd need to put a "@since New in 1.6" tag on the public
doc string.

But why do you need it to be public? Could you explain in more detail?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-23 03:30:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.