[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Svn_wc_set_changelist should clear it's own error (memory leak in +- all implementers of svn_wc_notify_func2) (Issue #3169)

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Thu, 22 May 2008 16:12:37 -0400

What became of this API-sensitive patch?

Bert Huijben wrote:
>> -----Original Message-----
>> From: sussman_at_gmail.com [mailto:sussman_at_gmail.com] On Behalf Of Ben
>> Collins-Sussman
>> Sent: donderdag 10 april 2008 17:29
>> To: Bert Huijben
>> Cc: dev_at_subversion.tigris.org
>> Subject: Re: Svn_wc_set_changelist should clear it's own error (memory
>> leak in +- all implementers of svn_wc_notify_func2) (Issue #3169)
>>
>> Care to send a patch?
>
> [[
> Removed unused svn_wc_notify_changelist_failed notification and moved the
> release
> of the err member passed to the notify function for
> svn_wc_notify_changelist_moved
> to the caller.
>
> This revision should partially be reverted if not merged to 1.5
>
> * subversion/include/svn_wc.h
> (svn_wc_notify_action_t) Removed unused svn_wc_notify_changelist_failed
>
> * subversion/libsvn_wc/adm_ops.c
> (svn_wc_set_changelist) Release the error passed to the notification
> handler
>
> * subversion/svn/notify.c
> (notify) Removed handling of the svn_wc_notify_changelist_failed and stop
> clearing the error passed to svn_wc_notify_changelist_moved.
>
> * subversion/bindings/javahl/native/EnumMapper.cpp
> (EnumMapper::mapNotifyAction) Removed mapping of
> svn_wc_notify_changelist_failed
>
> *
> subversion/bindings/javahl/src/org/tigris/subversion/javahl/NotifyAction.jav
> a
> (NotifyAction) Removed changelist_failed field and renumbered merge_begin
>
> Patch by: Bert Huijben <b.huijben_at_competence.biz>
> ]]
>
> If the patch is not merged to 1.5, all changes except those in notify.c and
> adm_ops.c must be reverted
>
> Bert
>
>
>
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: dev-help_at_subversion.tigris.org

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2008-05-22 22:12:54 CEST

This is an archived mail posted to the Subversion Dev mailing list.