On Thu, May 15, 2008 at 1:32 PM, Daniel Shahaf <d.s_at_daniel.shahaf.co.il> wrote:
> [ Summary: patch below works on Linux and breaks four regression test on
> Windows. ]
>
> jeremy hinds wrote on Fri, 25 Apr 2008 at 22:58 -0600:
>> [[[
>> In cmdline tests, use subprocess.Popen for executing commands to allow
>> support for exit-code checks on both Windows and posix systems. This makes
>> the test suite require Python version >= 2.4.
>>
>> * subversion/tests/cmdline/svntest/main.py
>> (global): Import subprocess instead of popen2. Remove variable
>> "platform_with_popen3_class".
>> (_quote_arg): Removed, since commands + args to open_pipe are now lists.
>> (open_pipe): Replace "mode" character parameter with a "binary_mode" boolean
>> value. Use subprocess.Popen for spawning the child process.
>> (wait_on_pipe): Interpret the return value of wait() according to
>> subprocess.Popen semantics.
>> (spawn_process, copy_repos): When calling open_pipe, pass the command as
>> a list and binary_mode as a boolean.
>> (run_svn2): New, like run_svn but with a "binary_mode" boolean param.
>> (TestSpawningThread.run_one): Remove the caveat comment stating that
>> result (exit-code) is None on Windows.
>>
>> * subversion/tests/cmdline/svntest/actions.py
>> (run_and_verify_svnlook, run_and_verify_svnlook2, run_and_verify_svnadmin,
>> run_and_verify_svnadmin2, run_and_verify_svnversion,
>> run_and_verify_svnversion2,
>> run_and_verify_svn_match_any, run_and_verify_svn_match_any2):
>> Remove the caveat comment stating that exit-code checks are skipped
>> for some platforms.
>> (run_and_verify_svn): Remove the caveat comment stating that exit-code
>> checks are skipped for some platforms. Pass binary_mode=0 to
>> run_and_verify_svn2.
>> (run_and_verify_svn2): Remove the caveat comment stating that exit-code
>> checks are skipped for some platforms. Add a binary_mode boolean
>> parameter. Replace call to run_svn with run_svn2.
>>
>> * subversion/tests/cmdline/import_tests.py
>> (import_eol_style): Call run_and_verify_svn2 with binary_mode=1.
>>
>> * subversion/tests/cmdline/cat_tests.py,
>> subversion/tests/cmdline/lock_tests.py,
>> subversion/tests/cmdline/stat_tests.py:
>> Pass binary_mode parameter to run_and_verify_svn2.
>>
>> ]]]
>
> Jeremy, what's the status of this patch? Are you looking into the
> Windows test failures?
>
Sorry - I haven't forgotten or given up on this, but I had to
side-line it for a while. I'm hoping to pick it up again soon.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-18 19:11:11 CEST