Re: svn commit: r31233 - branches/kwallet/subversion/libsvn_subr

Stefan Sperling wrote on Fri, 16 May 2008 at 22:33 +0200:
> On Fri, May 16, 2008 at 10:35:34PM +0300, Daniel Shahaf wrote:
> > Also, svn_dso_load is only declared and defined #if APR_HAS_DSO; and
> > /branches/kwallet/subversion/libsvn_subr/cmdline.c doesn't check for that
> > before calling it.
>
> Shouldn't the entire kwallet support depend upon APR_HAS_DSO then?
>

Does defined(SVN_HAVE_KWALLET) == TRUE imply APR_HAS_DSO == TRUE?

I don't see any explicit DSO checks in the kwallet branch (I grepped
r31241).

> Geez, this is getting so complicated...
> And I thought the plaintext stuff was hard :/
>
> Stefan
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-16 23:51:10 CEST