[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31233 - branches/kwallet/subversion/libsvn_subr

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Fri, 16 May 2008 22:35:34 +0300 (Jerusalem Daylight Time)

Daniel Shahaf wrote on Fri, 16 May 2008 at 22:31 +0300:
> Philip Martin wrote on Fri, 16 May 2008 at 19:47 +0100:
> > "Arfrever Frehtes Taifersar Arahesis" <arfrever.fta_at_gmail.com> writes:
> > > 2008-05-16 20:10 Philip Martin <philip_at_codematters.co.uk> napisał(a):
> > >> Can the function return something otherthan SVN_NO_ERROR?
> > >

Also, svn_dso_load is only declared and defined #if APR_HAS_DSO; and
/branches/kwallet/subversion/libsvn_subr/cmdline.c doesn't check for that
before calling it.

>
> Philip, the answer is "Yes".
>
> > > See subversion/libsvn_subr/dso.c.
> >
> > I'm still having difficulty understanding what you mean, could you
> > explain rather than simply providing hints. Are you relying on
> > undocumented behaviour? If you want to rely on the function never
> > returning an error then you should change the documentation at the
> > very least, and probably the function prototype as well.
> >
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-16 21:35:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.