Re: [Patch] Add '--with-revprop' to CHANGES file

Should be all the subcommands that do commits, right? (Those that take the
-m option.) Or, just grep the codebase for stuff that dereferences
ctx->revprop_table. Or, just remove the ctx_t member and let the compiler
tell ya about it. :-)

David Glasser wrote:
> By the way, Bert, if you already have an exact list of the APIs that
> have this issue, that would be great!
>
> --dave
>
> On Fri, May 16, 2008 at 3:36 AM, Bert Huijben (@home) <bert_at_vmoo.com> wrote:
>>> -----Original Message-----
>>> From: epg_at_gould.diplodocus.org [mailto:epg_at_gould.diplodocus.org] On
>>> Behalf Of Eric Gillespie
>>> Sent: donderdag 15 mei 2008 23:52
>>> To: dev_at_subversion.tigris.org
>>> Subject: Re: [Patch] Add '--with-revprop' to CHANGES file
>>>
>>> Karl Fogel <kfogel_at_red-bean.com> writes:
>>>
>>>> "Bert Huijben" <B.Huijben_at_competence.biz> writes:
>>>>> [[
>>>>> * CHANGES (1.5.0):
>>>>> Add line about --with-revprop (issue #1976)
>>>>>
>>>>> Patch by: Bert Huijben <b.huijben_at_competence.biz>
>>>>> ]]
>>>> Applied in r31202, thanks as always!
>>> Hmm, two comments about this:
>>>
>>> - The line about svn commit --with-revprop is now redundant, so
>>> remove it.
>> Still not sure why my search to anything with 'revprop' returned nothing in
>> the changes file.. :(
>>
>>> - "all commands taking '-m'"? What the heck does that mean? How
>>> about "all commands that commit a new revision"? I know
>>> fitting it into 80 columns is tough, but... Maybe just list
>>> them all? I don't think there are many:
>>>
>>> * svn commit/cp/mkdir/rm now take '--with-revprop' option (issue
>>> #1976)
>> Import and mv take it too. Karl fixed this to be 'all commands that commit'
>> which should summarize it properly (And fits within the 80 character limit).
>>
>> But I started looking at this when I looked at using it from the C api.
>>
>> I don't understand why this value is passed as a value in svn_client_ctx_t
>> instead of using a argument to svn_client_*() in the c api (We revved all
>> these functions in 1.5 anyway).
>>
>> It doesn't seem logical that I want to set the same extra revprops on every
>> command executed during the lifetime of my svn_client_ctx_t. (Many c-api
>> users don't recreate the client ctx for every command they use).
>>
>> Bert
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
>> For additional commands, e-mail: dev-help_at_subversion.tigris.org
>>
>>
>
>
>

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand