2008-05-16 20:10 Philip Martin <philip_at_codematters.co.uk> napisał(a):
> "Arfrever Frehtes Taifersar Arahesis" <arfrever.fta_at_gmail.com> writes:
>
>>>> - svn_dso_load(&dso, libname);
>>>> + svn_error_clear(svn_dso_load(&dso, libname));
>>>> if (dso)
>>>> {
>>>> if (! apr_dso_sym(&provider_symbol, dso, funcname))
>>>
>>> If svn_dso_load returns an error you cannot assume dso has a value you
>>> can check. Further, simply ignoring all errors makes it hard for
>>> users to debug problems with dynamic loading.
>>
>> /**
>> * Attempt to load @a libname, returning it in @a dso.
>> *
>> * If @a libname cannot be loaded set @a dso to NULL and return
>> * @c SVN_NO_ERROR.
>> *
>> * @note Due to pool lifetime issues DSOs are all loaded into a global
>> * pool, so you must be certain that there is a bounded number of
>> * them that will ever be loaded by the system, otherwise you will
>> * leak memory.
>> *
>> * @since New in 1.4.0.
>> */
>> svn_error_t *svn_dso_load(apr_dso_handle_t **dso, const char *libname);
>
> Was your mail incomplete, I'm not sure what point you are trying to
> make?
It was complete. I just quoted the part of subversion/include/svn_dso.h.
> Can the function return something otherthan SVN_NO_ERROR?
See subversion/libsvn_subr/dso.c.
Received on 2008-05-16 20:35:39 CEST