Re: kwallet branch is finished

On Wed, May 14, 2008 at 08:14:42PM +0200, Stefan Sperling wrote:
> On Wed, May 14, 2008 at 08:21:51PM +0300, Daniel Shahaf wrote:
> > Arfrever Frehtes Taifersar Arahesis wrote on Wed, 14 May 2008 at 16:10 +0200:
> > > 2008-05-13 21:46 Daniel Shahaf <d.s_at_daniel.shahaf.co.il> napisał(a):
> > > > Has anybody except you used the branch or reviewed it?
> > >
> > > The really new code is enabled only when the '--with-kwallet' option
> > > is passed to `configure`. In other places I only made relatively small
> > > non-functional changes (e.g. I renamed 2 private functions etc.).
> > >
> > > Did my answer dispel your fears?
> > >
> >
> > Your answer did not answer my question, which sought to estimate not the
> > amount of code changes in the branch but the amount of human attention
> > it has received.
>
> I would like to test the branch, but given that is needs KDE4,
> and KDE4 on FreeBSD is still very much work in progress
> (http://wiki.freebsd.org/KDE4) testing this seems to require
> quite some effort.

OK, I've tested the branch now. Got a VNC session to a friend's
box running KDE4 (many thanks!).

Quoting myself in IRC:

<stsp> the kwallet support works fine for me
<stsp> quite nice
<stsp> just had to tweak LD_LIBRARY_PATH to make it pick up the lib from the installation prefix in my home directory on the system I'm testing on
<stsp> once that's done, you get a popup that asks you for the wallet password
<stsp> on the next run it does not bother you again :)

So yeah, I admit this test was pretty basic, but it's late here
and I'm too tired right now to do proper code review. Luckily
others have started reviewing the code already, so all I can do at
this point is adding another pair of eyes anyway.

Well, at least I've seen it run, and it runs really well :)

Thanks for your work on this Arfrever,

Stefan