[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: kwallet branch is finished

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: Thu, 15 May 2008 14:33:12 -0500

On Thu, May 15, 2008 at 1:42 PM, Daniel Shahaf <d.s_at_daniel.shahaf.co.il> wrote:
> Ben Collins-Sussman wrote on Thu, 15 May 2008 at 13:32 -0500:
>> On Thu, May 15, 2008 at 1:06 PM, Daniel Shahaf <d.s_at_daniel.shahaf.co.il> wrote:
>> > Ben Collins-Sussman wrote on Thu, 15 May 2008 at 13:01 -0500:
>> > > On Thu, May 15, 2008 at 12:57 PM, Daniel Shahaf <d.s_at_daniel.shahaf.co.il> wrote:
>> > >
>> > > > To clarify: whenever svn_auth_get_kwallet_simple_provider was declared
>> > > > in svn_auth.h -- even if its declaration was inside a "#if 0" block --
>> > > > Visual Studio added it to the symbols list in 'libsvn_subr.def' and
>> > > > tried to compile a 'kwallet.obj' file. (The libsvn_subr.def file is
>> > > > generated by VC, not by the Python scripts.)
>> > >
>> > > Why doesn't Visual Studio have this same problem for
>> > > svn_auth_get_keychain_simple_provider?
>> > >
>> >
>> > Because keychain is not a separate library and kwallet is?
>> >
>> > % grep kwallet build.conf
>> > [libsvn_auth_kwallet]
>> > install = kwallet-lib
>> > path = subversion/libsvn_auth_kwallet
>> > libs = apr kwallet libsvn_subr
>> > [kwallet]
>> >
>>
>> OK, one step further: we have other dynamically-loaded libraries that
>> aren't causing problems like this on Windows. Take libsvn_fs_base,
>> for example. BDB isn't always available... what does Visual Studio do
>> in this situation?
>>
>
> gen-make.py doesn't generate VC projects for BDB unless the argument
> --with-berkeley-db is given to it.

Why can't we imitate this for gnome and kde? In other words, let
configure.ac notice gnome and/or kde, and pass 'activation' flags to
gen-make.py if proper libraries are found. This means that
gen-make.py won't generate any libsvn_auth_kwallet information when
run on Windows. When it runs on Linux, it *might* generate a Makefile
target. Regardless, when running on Linux, the dso_load() is still
attempted (and non-fatal if not found.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-15 21:33:54 CEST

This is an archived mail posted to the Subversion Dev mailing list.