[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: kwallet final branch

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Thu, 15 May 2008 13:49:55 -0400

Martin Furter <mf_at_rola.ch> writes:
>> On Thu, May 15, 2008 at 10:41 AM, Karl Fogel <kfogel_at_red-bean.com> wrote:
>>> svncodereview_at_gmail.com writes:
>>> > New code review comments by sussman have been published.
>>> > Please go to http://codereview.appspot.com/989 to read them.
>>>
>>> Neat! But is there any way to configure it so that the (e.g.) output
>>> below includes diff context along with the comments? The rest of this
>>> mail is significantly less useful for not being self-contained: unless
>>> one knows the code *really* well, one has to constantly flip back and
>>> forth between the mail and other files / web pages in order to
>>> understand the comments. I get that one is supposed to just go to the
>>> main URL above (and I have), but presumably the rest of the mail was
>>> intended to be useful...
>>
>> I don't think the mail is intended to be useful by itself. It's just
>> an 'overview' of comments, and a signal that one should go to the real
>> website and respond to the comment-annotations directly.
>
> Isn't "useless email" called SPAM? ;)

First, no :-). But second, I didn't say the mail was useless, I said
part of it was useless. The other part was useful. Ben was perhaps not
speaking precisely, but I think his meaning was clear.

> Btw. is there no way to see all files with all diffs and comments at once?

I don't know, but codereview.appspot.com is itself an open source
project, so their answer to this might be "Patches welcome!".
http://groups.google.com/group/codereview-discuss is probably a good
place to start.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-15 19:50:09 CEST

This is an archived mail posted to the Subversion Dev mailing list.