Re: [PATCH] Fix issue #2324

Hi,

David Glasser wrote:
>> <snip>
>> [groups]
>> group1 = *.collab.net
>> othergroup = repository.blarggitywhoomph.com
>>
>> ### Information for the first group:
>> [group1]
>> http-proxy-host = proxy1.some-domain-name.com
>> http-proxy-port = 80
>> http-proxy-username = blah
>> http-proxy-password = doubleblah
>> http-timeout = 60
>> http-auth-types = basic;digest;negotiate
>> neon-debug-mask = 130
>> username = stylesen
>>
>> ### Information for the second group:
>> [othergroup]
>> http-proxy-host = proxy2.some-domain-name.com
>> http-proxy-port = 9000
>> username = harry
>>
>> [global]
>> http-proxy-exceptions = *.exception.com, www.internal-site.org
>> http-proxy-host = defaultproxy.whatever.com
>> http-proxy-port = 7000
>> http-proxy-username = defaultusername
>> http-proxy-password = defaultpassword
>> username = sally
>> </snip>
>
> Yup, that's the sort of thing I'm thinking about.

I am attaching an updated patch along with this email as per Dave's suggestion
for adding the username in the servers file.

[[[
Fix issue #2324.

Disable username assumption.

* subversion/include/svn_config.h
   (): Add SVN_CONFIG_OPTION_USERNAME.

* subversion/libsvn_subr/config_file.c
   (svn_config_ensure): Add text about the new config file parameter 'username'.

* subversion/libsvn_subr/simple_providers.c
   (simple_first_creds_helper): Fetch username from servers file if it is
    defined.
   (prompt_for_simple_creds): If we didnt get a password in
    simple_first_creds_helper then we need to get the username again here.

Patch by: stylesen
]]]

Thank You.

-- 
Senthil Kumaran S
http://www.stylesen.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org