Re: [PATCH] ISSUE #3193 Fix peg revision parsing for CLI repository root relative urls.

Troy Curtis Jr wrote on Mon, 12 May 2008 at 21:56 -0500:
> On Mon, May 12, 2008 at 11:29 AM, Daniel Shahaf <d.s_at_daniel.shahaf.co.il> wrote:
> > Troy Curtis Jr wrote on Mon, 12 May 2008 at 06:49 -0500:
> >> I'm still learning about all this 'canonical' stuff, but if a
> >> zero-length path is considered canonical then should this function
> >> support that? Will apr_pstrmemdup() not output an empty path?
> >>
> >
> > Except the paths passed to this function are not canonical; they are user
> > input. If we allow the empty string here, wouldn't it allow
> >
> > svn up ''
> >
> > as synonym for
> >
> > svn up '.'
> >
>
> Makes sense to me, especially because I think the '.' is typically
> canonicalized to '' anyway, right? (Again don't be too hard on me,
> I'm still learning all this canonical stuff).
>

Right; but I don't think we should support '' as a synonym for '.'
in the UI :)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-13 21:08:03 CEST