Re: [PATCH] Fix merging with broken softlink as target

On 12/05/2008 21:26, Karl Fogel wrote:
> Karl Fogel <kfogel_at_red-bean.com> writes:
>> Hmmm. If the goal is to check for symlinks, not just specialness, maybe
>> it would be a good idea to check that the contents of the special file
>> begins with "link:", indicating a symlink? There may be other kinds of
>> special files in the future...
>>
>> Hmm, then again, it's highly likely that future kinds of special files
>> would want the same treatment anyway. So I've just adjusted the comment
>> a bit to talk about that; I'm running 'make check' now (paranoia, I know
>> you already did it) and will commit soon.

Yes, that thought did occur to me but I came to the same conclusion - I
guess I should have made this obvious in the comment - sorry!

> Hmmm. I'm still getting a failure over ra_neon:
>
> prop_tests.py 26: test handling invalid svn:* property values
>
> When I say I run 'make check', what I really mean is I run the
> regression test suite over at least three RA layers:
>
> make check CLEANUP=true
> make svncheck CLEANUP=true
> make neoncheck CLEANUP=true
> make serfcheck CLEANUP=true /* Usually run this, not always */

I have neither neoncheck nor serfcheck targets in my makefile. FC8 comes
with neon 0.25.5 which configure seems to pick up alright and the build
did produce libsvn_ra_neon-1.a.

> The above failure is from 'make neoncheck'. Do you know what's causing
> it? (I haven't looked into it yet, having choosen instead to
> shamelessly toss the ball back into your court :-) .)

Luckily for me Daniel has taken responsibility for this one :-)

David.

-- 
The information contained in this e-mail and in any attachments is confidential and is designated solely for the attention of the intended recipient(s). If you are not an intended recipient, you must not use, disclose, copy, distribute or retain this e-mail or any part thereof. If you have received this e-mail in error, please notify the sender by return e-mail and delete all copies of this e-mail from your computer system(s).
Please direct any additional queries to: communications_at_s3group.com.
Thank You.
Silicon and Software Systems Limited. Registered in Ireland no. 378073.
Registered Office: South County Business Park, Leopardstown, Dublin 18
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org