[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r31121 - in trunk: . subversion/libsvn_subr subversion/tests/libsvn_subr

From: Stefan Sperling <stsp_at_elego.de>
Date: Mon, 12 May 2008 13:56:28 +0200

On Mon, May 12, 2008 at 05:14:41PM +0530, Kamesh Jayachandran wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi,
>
> This commit causes(actually reveals the hiding path inconsistencies)
> many tests to fail over ra_neon on --enable-maintainer-mode build.

Oh, I'm not testing with ra_neon, maybe I should?

> Following patch is supposed to fix it. Once the tests are over will
> commit the same.

Yay, one more bug fixed because of improved debugging code :)

Thanks Kamesh,
Stefan

>
>
> Index: subversion/libsvn_ra_neon/util.c
> ===================================================================
> - --- subversion/libsvn_ra_neon/util.c (revision 31132)
> +++ subversion/libsvn_ra_neon/util.c (working copy)
> @@ -510,8 +510,10 @@
> */
>
> apr_uri_t uri;
> - - apr_status_t apr_status
> - - = apr_uri_parse(pool, src, &uri);
> + apr_status_t apr_status;
> + /* SRC can have trailing '/' */
> + src = svn_path_canonicalize(src, pool);
> + apr_status = apr_uri_parse(pool, src, &uri);
>
> if (apr_status != APR_SUCCESS)
> return svn_error_wrap_apr(apr_status,

  • application/pgp-signature attachment: stored
Received on 2008-05-12 13:55:14 CEST

This is an archived mail posted to the Subversion Dev mailing list.