Re: [PATCH 1 of 2] Add peg revision support to svn_opt__arg_canonicalize_*()

On Sat, May 10, 2008 at 11:08 AM, Daniel Shahaf <d.s_at_daniel.shahaf.co.il> wrote:
> Troy Curtis Jr wrote on Wed, 30 Apr 2008 at 22:28 -0500:
>> This is the first part of the patch necessary to address correctly handling
>> peg revision specifications in repository root urls.
>>
>
> Filed both patches as issue #3193 with milestone 1.6-consider. Troy, I
> didn't CC or assign to you because I don't know your tigris username.
>

Neither do I as I don't have one!

I'm almost done with a patch which incorporates your suggestion of
putting my split_arg_at_peg_revision() into svn_opt_parse_path().

Troy
> http://subversion.tigris.org/issues/show_bug.cgi?id=3193
>
> Daniel
>
>> [[[
>> Add peg revision support to svn_opt__arg_canonicalize_url() and
>> svn_opt__arg_canonicalize_path(). These functions are meant to process
>> user-input and so should handle the peg revision case.
>>
>> * subversion/libsvn_subr/opt.c
>> (split_arg_at_peg_revision): New function.
>> (svn_opt__arg_canonicalize_url,
>> svn_opt__arg_canonicalize_path): Allow the input argument to contain a peg
>> revision specifier, and preserve it in the output utilizing
>> split_arg_at_peg_revision().
>>
>> * subversion/include/private/svn_opt_private.h
>> (svn_opt__arg_canonicalize_url,
>> svn_opt__arg_canonicalize_path): Update the doc string to reflect the fact
>> that these functions can handle a peg revision in the input argument.
>> ]]]
>>
>>
>

-- 
"Beware of spyware. If you can, use the Firefox browser." - USA Today
Download now at http://getfirefox.com
Registered Linux User #354814 ( http://counter.li.org/)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org