[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: kwallet branch is finished

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: Sat, 10 May 2008 14:21:47 -0500

By the way, I wanted people to see this new code-review tool:

  http://codereview.appspot.com/716

People may have heard that Guido van Rossum wrote this awesome
web-based code-review tool called 'mondrian', used like crazy within
Google. Problem is, it's tightly tied to perforce and google's
internal infrastructure. When Google released its new "app hosting"
service a couple of weeks ago, Guido was one of the first people to
publicize a new public (open source) application running on the
apphosting infrastructure: it's basically another code review tool
that works with Subversion, specifically. And it looks and feels a
*whole* lot like mondrian.

The basic jist (for now) is that you upload a patchfile as an 'issue'.
 Then you can click through each file, view side-by-side diffs, and
then add commentary to the code by double-clicking on a line number.
A little box pops up right on the web page and allows you to insert
comments. When you're all done attaching comments to the code, the
system allows you to mail all the comments off to a person (or the
dev@ list) as a normal code review. The reviewers and reviewee can go
back and forth with the review, right within the web UI. It's pretty
amazing stuff, and has made a world of difference in productivity
within google; folks used to do code reviews purely over email, but
now we use the web UI and let email simply be the dangling 'audit
trail' of the interaction.

In any case, as an example, I uploaded a patch of Arfrever's kwallet
changes above. Try making some comments on it. :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-10 21:22:01 CEST

This is an archived mail posted to the Subversion Dev mailing list.