[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: WIN32_RETRY_LOOP on Cygwin

From: Spiro Trikaliotis <news-200803_at_trikaliotis.net>
Date: Sat, 10 May 2008 11:14:42 +0200

Hello Max,

thank you for your reply, and I am sorry for my late reply.

Max Bowsher wrote:

> Karl Fogel wrote:
>> Spiro Trikaliotis <news-200803_at_trikaliotis.net> writes:
>>> In subversion-1.5.0-rc4/subversion/libsvn_subr/io.c, the
>>> WIN32_RETRY_LOOP is defined as loop only if WIN32 is defined.
>>> Unfortunately, for Cygwin, this means that this work-aroundy is not
>>> performed, as WIN32 is not defined there.
[...]
>> I don't have enough background knowledge to anticipate all the "gotchas"
>> here, but this seems reasonable to me.
[...]
>> However, I'd like to hear comments from other developers with more
>> Windows and Cygwin experience...
>
> I guess as former Subversion Cygwin package maintainer, I should pipe up
> here. (former, because I resigned yesterday, having completed the
> transition to a Microsoft-free computing experience just this week)

Congratulations to the transistion. Unfortunately, this is something not
everyone can afford.

> People occasionally would suggest using WIN32_RETRY_LOOP on Cygwin. I
> never patched it into the Cygwin packages during my tenure, because I
> never once experienced any Subversion operation failing in a relevant
> way. But then, perhaps that's because I was just lucky, and tended to
> run a fairly clean system. *shrug*

Well, this was true for me, too, before my Antivirus company decided to
release a newer main version of the tool. It was then when this problem
started...

>> Hmmm, how does Subversion determine the "native" end-of-line convention?
>> I'd think we just ask APR somehow; if so, the question is, why isn't APR
>> getting the right answer on Cygwin?
>
> native == APR_EOL_STR, a preprocessor constant. Which is fine. Except
> that on Cygwin, the choice of what the intended on-disk eol style should
> be can be configured on *per-directory* basis. I took one look at how
> much libsvn_subr assumes that the native eol is a simple compile-time
> constant, and punted on trying to change anything here.

So, it seems the best way to solve this for me is to compile SVN myself
and replace that APR_EOL_STR to CRLF, right?

Regards,
   Spiro.

-- 
Spiro R. Trikaliotis                              http://opencbm.sf.net/
http://www.trikaliotis.net/                     http://www.viceteam.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-10 12:30:27 CEST

This is an archived mail posted to the Subversion Dev mailing list.