[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Adapting svnstsw to use Subversion's build system

From: Richard Hansen <rhansen_at_bbn.com>
Date: Thu, 08 May 2008 18:32:43 -0400

Max Bowsher wrote:
>> However, AC_PROG_CC_C99 has a side effect that affects everything: it
>> alters the default CC variable, so instead of CC=gcc, you get CC="gcc
>> -std=gnu99". I don't expect this to cause any problems, but I'm not
>> really sure.
>
> Um. That's definitely not acceptable. Do:
>
> save_CC=$CC
> AC_PROG_CC_C99
> CC_C99=$CC
> CC=$save_CC
>
> and arrange for svnstsw to use CC_C99.

Good idea.

>> Maybe it is a little redundant, but I think that integrating the code
>> as-is into the build system is still worthwhile. I don't know what the
>> policy is for patch-release changes, but I can see svnstsw making it
>> into a future 1.5.x release once the build system integration happens.
>> I wouldn't expect any changes to svnserve to make it into a release
>> before 1.6.0 (because of backwards-compatibility issues). Thus,
>> build-system integration should allow us to put the functionality into
>> users' hands quickly.
>>
>> Besides, build-system integration should be easier, so if something
>> comes up and I can't dedicate the time to integrate the svnstsw
>> functionality into svnserve, at least users will have something.
>
> Sorry to disappoint, but the rule is generally "bugfixes *only*". The
> buildsystem is a complex and somewhat finicky beast - I think it
> unlikely we'd allow this sort of thing in a patch release.

Probably a good idea. I still think I would prefer to make the changes
in two stages: First, integrate the existing code into the build
system. Second, integrate the functionality into svnserve after
resolving any backwards-compatibility and portability issues.

I'll make a branch and start coding. I'm doing this in my spare time,
so don't expect me to make rapid progress. :)

-Richard

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-09 00:32:56 CEST

This is an archived mail posted to the Subversion Dev mailing list.