Re: [PATCH] Cache ssl client certificate passphrases

On Thu, May 08, 2008 at 02:37:54PM +0530, Senthil Kumaran S wrote:
> Hi Stefan,
>
> Stefan Sperling wrote:
>> could we have the default be 'no' (easy), or add a prompt similar to
>
> I am attaching an updated patch which has the default as 'no'.

Hey, that was quick, thanks :)

I'm glad this didn't end up being another flame war between
people who want plaintext caching and people who don't ;)

How can I help you test this? Didn't you mention some day in IRC
that you figured out how to create a client certificate with
a passphrase? Does the server have to know about the client
somehow? Would I have to set up a server? Or could I test against
some server you are testing against as well?

One minor nit:

> Index: subversion/libsvn_subr/ssl_client_cert_pw_providers.c
> ===================================================================
> --- subversion/libsvn_subr/ssl_client_cert_pw_providers.c (revision 31082)
> +++ subversion/libsvn_subr/ssl_client_cert_pw_providers.c (working copy)

> @@ -53,6 +57,29 @@
> svn_config_get_server_setting(cfg, server_group,

> + if (str && str->data)
> + password = str->data;

The indentation here looks wrong.

Thanks for working on this feature,

Stefan