[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] clean up some debugging code

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 8 May 2008 10:26:24 +0200

On Thu, May 08, 2008 at 10:19:34AM +0200, Stefan Sperling wrote:
> Hi,
>
> comments, anyone?
>
> I'd like to commit this, but have one open question (read the log
> message first, my question is below).
>
> The patch passes 'make check'.

> @@ -347,7 +367,7 @@ svn_path_add_component(svn_stringbuf_t *path,
> void
> svn_path_remove_component(svn_stringbuf_t *path)
> {
> - assert(is_canonical(path->data, path->len));
> + assert(is_canonical(path->data, strlen(path->data)));

Mmmmh. There's a few redundant strlen calls in it now alright,
they happened because I did a global search/replace edit.

I will fix those, i.e. use ->len again where possible, before commit.

Stefan

  • application/pgp-signature attachment: stored
Received on 2008-05-08 10:24:42 CEST

This is an archived mail posted to the Subversion Dev mailing list.