[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_wc_add3(): handles depth on add

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Tue, 06 May 2008 15:03:04 -0400

"Rui, Guo" <timmyguo_at_mail.ustc.edu.cn> writes:
> And about the grammar pitfall, the problem of mismatching singular and plural
> is hard to catch my attention even when I'm checking for them, shy. This
> problem seems common to Chinese English speakers since we do not distinguish
> them in our mother tongue.

我知道,没问题 :-).

>> So I reverted the patch and tried with a clean trunk_at_r31039. This time,
>> no failures. Could you look into this, please? Here's the adjusted
>> version of the patch that I used. It should be functionally the same as
>> yours, I only tweaked comments and formatting.
>
> I should say sorry, Karl, for wasting your time on this. I admit that I did
> not run a full check (too slow, don't you think?) before I submit the patch,
> or I would have discovered this by myself.

Oh, actually, it's okay to post a patch for review without first running
'make check'. Just make sure you say that in your mail, so people know
what to expect.

> The problem is that the "svn_client__make_local_parents()" function, which is
> called by mkdir & copy logic, used a hard-coded svn_depth_empty when calling
> svn_client_add4() to add it to the repository. This is OK before the patch is
> applied, however, problem arise now since the depth of new directory is
> unexpectedly set to empty. Changing the constant to svn_depth_infinity fixes
> all the above failure.

Ah, okay.

> When digging into this problem, I found that 'svn merge' will still incur
> local modification (to its children)even when --depth is empty, is this okay?

I didn't quite understand. Can you explain that in more words?

Thanks,
-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-06 21:03:23 CEST

This is an archived mail posted to the Subversion Dev mailing list.