[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] RE: Commit strips common prefix instead of current directory (Issue #3168)

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Tue, 6 May 2008 20:25:47 +0300 (Jerusalem Daylight Time)

Bert Huijben wrote on Tue, 6 May 2008 at 11:28 +0200:
> Karl Fogel wrote:
> > ### If possible, it's best to submit those other cleanups as a
> > ### separate patch. I know it's slightly more work, but it really
> > ### helps keep things simple for reviewers.
>
> If I had used two patches they would not apply cleanly if used
> separately (and once applied I merge this patch in the SharpSvn builds
> to fix some AnkhSvn issues).
> (Didn't change this for the updated patch)
>

It is okay to split a submission into two related patches that depend on
each other. Just make sure to state the dependencies clearly.

As Karl said, splitting changes into small, separate patches also help
reviewers, since small changes are easier and faster to understand.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-06 19:26:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.