[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Adapting svnstsw to use Subversion's build system

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: Mon, 05 May 2008 16:04:28 -0400

On Mon, 2008-05-05 at 12:38 -0700, Blair Zajac wrote:
> > 6. svnstsw makes heavy use of C99 features. Would it be OK to add the
> > AC_PROG_CC_C99 autoconf test to an .m4 file and only compile svnstsw if
> > 'x${ac_cv_prog_cc_c99}' != 'xno'? Or is this too invasive?
>
> Which features does it use?

Peering at the source code, I see a lot of // comments and a lot of
mixed code and declarations.

I have to apologize in advance for sounding kind of harsh, and please
keep in mind that I don't speak for the Subversion project in any way
since I have not been doing active development. That said:

* This is a simple wrapper program, but it has been coded as a
capital-p-Project. It has five source files and 1939 lines of code
(mostly comments), separate src/ and include/ directories, and man pages
for the internal functions contained within. The ratio of overhead to
actual functionality is off the chart, especially for a program which
ought to be easy to audit (since it runs with elevated privileges).

* Although we don't take responsibility for maintaining the stuff under
contrib, we do take some responsibility for building it. That means
code under there needs to adhere at least minimally to project
standards, including using C89 for C code. It would be disappointing to
see stuff added to the project's main autoconf grot in order to support
a contrib program. Maybe the C99 check breaks on some people's machines
and they can't build Subversion, even though Subversion proper depends
only on C89.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-05 22:04:53 CEST

This is an archived mail posted to the Subversion Dev mailing list.