[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] RE: Commit strips common prefix instead of current directory (Issue #3168)

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Mon, 5 May 2008 20:22:03 +0300 (Jerusalem Daylight Time)

Patch manager hat on.

Bert Huijben wrote on Mon, 5 May 2008 at 15:49 +0200:
> [[
> Moved the creation of the final display paths to the cli notification
> handler, to
> make sure notifications always receive a valid path in the path field.
>
> * subversion/include/svn_wc.h
> (svn_wc_notify_t) Added path_prefix containing an absolute prefix
> which
> can be subtracted from the absolute path passed. Noted versions in
> which
> new fields where added.
>
> * subversion/libsvn_wc/util.c
> (svn_wc_create_notify, svn_wc_dup_notify) Added path_prefix handling
>
> * subversion/libsvn_client/client.h
> (svn_client__do_commit) Updated documentation to document the new
> handling
> of notify_path_prefix
>
> * subversion/libsvn_client/commit_util.c
> (svn_client__do_commit, do_item_commit) Removed local handling of
> notify_path_prefix. Instead pass the prefix path via path_prefix to
> the
> notification handler.
>
> * subversion/libsvn_client/commit.c
> (svn_client_commit4) Document the calculation of the notify prefix by
> renaming
> and adding a local variable.
>
> * subversion/svn/notify.c
> (notify) Use the new path_prefix to split the first part of the path
> if it
> matches the specified prefix. Don't bother testing for urls as the
> path is documented
> to be a local path.
>
> Patch by: Bert Huijben <b.huijben_at_competence.biz
> ]]
>

Numerous stylistic violations here in the log message (four different
issues, at least). Please pay more attention to adhering to our
log message format; badly formatted log messages are as much of an
obstacle to our processing a patch as any issue in the code itself.
Thank you.

Thanks for sending it text/plain,

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-05 19:22:45 CEST

This is an archived mail posted to the Subversion Dev mailing list.