[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] 'svn mkdir --parents' shows absolute paths

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Sat, 3 May 2008 10:38:01 +0300 (IDT)

Daniel Shahaf wrote on Fri, 2 May 2008 at 14:45 +0300:
> > Daniel Shahaf wrote:
> > > Kamesh Jayachandran wrote on Fri, 2 May 2008 at 16:13 +0530:
> > >> from_svn_wc/a/b/c/d$svn mkdir --parents .
> > >> Segmentation fault with your patch.
> > >>
> > >
> > > Also without it. With current (unpatched) trunk:
> > >
> > > 0:% svnversion
> > > exported
> > > 0:% svn mkdir --parents .
> > > lt-svn: subversion/libsvn_subr/path.c:119: svn_path_join: Assertion
> > > `is_canonical(base, blen)' failed.
> > > zsh: abort svn mkdir --parents .
> > >
> > > 0:% svn info | grep URL
> > > URL: https://svn.collab.net/repos/svn/trunk
> > > 0:% svn mkdir --parents .
> > > lt-svn: subversion/libsvn_subr/path.c:119: svn_path_join: Assertion
> > > `is_canonical(base, blen)' failed.
> > > zsh: abort svn mkdir --parents .
> >
> Earlier, I noticed that the assertion failure I reported earlier is
> due to svn_io_remove_dir2() changing "" to "." (so APR likes it). It
> surprised me -- why should mkdir need to call remove_dir() ?
>
> I can reproduce both bugs with 1.5_at_HEAD too.
>

Fixed the API issue underlying the 'mkdir --parents .' bug (which
Kamesh's r30931 fix had masked) in r30986, and nominated for backport.

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-03 09:38:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.