[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r30931 - trunk/subversion/libsvn_client

From: David Glasser <glasser_at_davidglasser.net>
Date: Fri, 2 May 2008 10:55:10 -0700

On Fri, May 2, 2008 at 10:32 AM, Karl Fogel <kfogel_at_red-bean.com> wrote:
> "David Glasser" <glasser_at_davidglasser.net> writes:
> > Is your "(as either a file or a directory)" parenthetical accurate?
> > Ie, would it actually delete /tmp/abc if it were a file? If so, I
> > don't think this revision would fix that.
>
> On re-reading the code, I think you're right, but only because there'd
> be nothing to fix -- there's no bug in the file case. Rather, either
> svn_io_make_dir_recursively() would error first, or orig_kind would not
> be none.

Right, that's what I thought, but if that wasn't the case, it would be
problematic.

--dave

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-02 19:55:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.