Re: [PATCH] MacOSX system proxy fallback

Hi,

anyone running MacOSX here who can review this simple patch? :)

Martin Hauner wrote:
> Hi,
>
> here is a patch that improves MacOSX usability by adding support for web
> proxy settings configured in the MacOSX network location settings.
>
> The patch makes it unnecessary to edit svn's proxy settings when moving
> between a location with proxy (e.g. at work) and a location without
> proxy (e.g. home).
>
> It works by checking the system proxy settings if svn didn't find
> a proxy in its 'server' configuration file. It is enabled by default.
>
> It can be disabled by setting "http-system-proxy" to "no" in the global
> server settings file. So far it works only for proxies without username
> and password. On non MacOSX systems it does nothing.
>
> [[[
> Fallback to system web proxy settings if no proxy is found based on the
> 'servers' configuration file. Set 'http-system-proxy' to 'no' in the
> 'global' section of the 'servers' configuration file to disable system
> proxy fallback.
>
> This is currently implemented for MacOSX only. On the other systems it
> does nothing.
>
>
> * configure.ac
> add system configuration framework to link libraries on MacOSX.
>
> * subversion/include/svn_config.h
> (SVN_CONFIG_OPTION_HTTP_SYSTEM_PROXY): new configration key.
>
> * subversion/libsvn_subr/config_file.c
> (svn_config_ensure): added 'http-system-proxy' description.
>
> * subversion/libsvn_ra_neon/session.c
> (get_system_proxy): new function, get the system web proxy settings.
> (get_server_settings): added system proxy setting fallback.
> ]]]
>
>
>
> -- Martin
>
> Subcommander 2.0.0 beta, 1.2.2, http://subcommander.tigris.org
> a cross platform Win32/Unix/MacOSX subversion GUI client & diff/merge tool.

-- 
Martin
Subcommander 2.0.0 Beta 2, 1.2.4 - http://subcommander.tigris.org
a Win32/Unix/MacOSX subversion GUI client & diff/merge tool.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org