[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_io_check_path's docstring ambiguous?

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Fri, 2 May 2008 18:32:39 +0300 (IDT)

Karl Fogel wrote on Fri, 2 May 2008 at 11:21 -0400:
> Daniel Shahaf <d.s_at_daniel.shahaf.co.il> writes:
> > svn_io_check_path's docstring reads:
> >
> > [...]
> >
> > As I read it, this specifies three non-exclusive cases:
> >
> > [1] path does not exist => svn_node_unknown
> > [2] path's parent is absent => *undefined*
> > [3] path's parent exist
> > && path does not exist => svn_node_none
> >
> > After discussion with Kamesh on IRC, we assumed that the intended
> > behaviour is as documented in svn_node_kind_t:
> >
> > [...]
> >
> > Proposed fix:
> >
> > [...]
>
> +1, and the new doc string does seem to match the current behavior. But
> as long as we're fixing the doc string, let's put it in the active voice,
> which is slightly easier to absorb I think:

Okay. Committed your version in r30937 and nominated for backport.

Thanks,

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-02 17:33:03 CEST

This is an archived mail posted to the Subversion Dev mailing list.