[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] [gnome-keyring] Miscellaneous improvements

From: Branko Čibej <brane_at_xbc.nu>
Date: Thu, 01 May 2008 22:30:04 +0200

Arfrever Frehtes Taifersar Arahesis wrote:
> 2008-05-01 22:00:59 Branko Čibej napisał(a):
>> Arfrever Frehtes Taifersar Arahesis wrote:
>>> When GNOME Keyring was found, SVN_HAVE_GNOME_KEYRING is defined in
>>> svn_private_config.h but this file is never installed.
>>> I think that svn_auth_get_gnome_keyring_simple_provider should be always
>>> defined but it shouldn't provide real support for GNOME Keyring when
>>> Subversion was built without --with-gnome-keyring.
>> Why not? Ideally the keyring store would kick in if the necessary
>> support is detected at runtime. It seems like a shame to have two
>> different svn executables, e.g., one for UI-less ubuntu-server and one
>> for ubuntu-desktop.
>> For example, the Windows CryptoAPI-based password store is always
>> compiled in, but checks for CrytoAPI presence at runtime, so you don't
>> need a specially compiled svn.exe for, e.g., Win98 (and all gods help
>> anyone who's still using that).
> Support for KWallet requires Qt{Core,DBus,Gui} 4 and KDELibs 4 at build time.
> I guess that support for GNOME Keyring has analogical requirements.

Oh, but build time is a different beast. You can have all of those libs
installed on a build machine. That's an acceptable overhead if it means
you don't end up with a myriad svn binaries, all alike, with a grue in
one of them.

-- Brane

To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-01 22:30:30 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.