Re: [PATCH] [gnome-keyring] Miscellaneous improvements

Arfrever Frehtes Taifersar Arahesis wrote:
> When GNOME Keyring was found, SVN_HAVE_GNOME_KEYRING is defined in
> svn_private_config.h but this file is never installed.
> I think that svn_auth_get_gnome_keyring_simple_provider should be always
> defined but it shouldn't provide real support for GNOME Keyring when
> Subversion was built without --with-gnome-keyring.
>

Why not? Ideally the keyring store would kick in if the necessary
support is detected at runtime. It seems like a shame to have two
different svn executables, e.g., one for UI-less ubuntu-server and one
for ubuntu-desktop.

For example, the Windows CryptoAPI-based password store is always
compiled in, but checks for CrytoAPI presence at runtime, so you don't
need a specially compiled svn.exe for, e.g., Win98 (and all gods help
anyone who's still using that).

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-01 22:01:25 CEST