[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] RE: Commit strips common prefix instead of current directory (Issue #3168)

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Thu, 01 May 2008 14:03:09 -0400

"Bert Huijben (TCG)" <b.huijben_at_competence.biz> writes:
> So both functions work correctly, following their own definition.. But the
> result of those two combined is commit notifications use a not-relative and
> a not-absolute path. (Which breaks using the notifications to keep an in
> memory-file-state-cache up to date).
>
> The real problem is: How can we fix this?
>
> A user does not expect to see absolute paths when committing, unless he
> passed absolute paths to 'svn ci' and he does not expect to see relative
> paths if he passed only absolute paths.

Hmmm, yeah, choosing a good behavior here is hard. The primary goal is
predictability, I would think. One possibility, off the top of my head:

   1. If any path was absolute, print all paths as absolute.

   2. Otherwise, print all paths as relative to the top ("root") of the
      working copy, OR:

      Print them relative to cwd iff cwd is a (grand, etc)parent of all
      the committed paths, else default to relative-to-root-of-wc.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-05-01 20:03:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.