Re: [PATCH] Fixes for CLI repository root relative url support

On Tue, Apr 29, 2008 at 5:22 PM, Blair Zajac <blair_at_orcaware.com> wrote:
> Hi Tony,
>
> It would be nice to split these patches up into separate logical changes;
> it would make the review easier. For example, the change to split
> split_arg_at_peg_revision() out should be a separate patch would leave the
> logical changes in the successive patch.
>
> The reviews would probably be faster this way also, less to keep track of.
>
> Regards,
> Blair
>
>

s/Tony/Troy/...I get that all the time :)

I'm not surprised that it was suggested that I split the patch, but
where you are proposing does seem odd to me. Perhaps it's because
it's too large a patch to quickly review :)

I had initially thought that I should include the fix for a failed
assert when a user entered a non-canonical repo root relative target,
but then decided it fit with what I was already doing. Guess not.

But I'm curious about your suggestion. split_arg_at_peg_revision()
was created to factor out (move) common code from inside
svn_client_args_to_target_array() and svn_opt_args_to_target_array3().
 Are you proposing that I create the common code (copy) submit that as
a patch. Then in a follow up actually change the code in the
*to_target_array() functions to use the new function? I must admit I
don't understand that.

Troy

>
> Troy Curtis Jr wrote:
>
> > Here are my fixes for the issues brought up last night and earlier today.
> The
> > tests are not in C because they require a working copy and repository
> > structure like that provided in cmdline.
> >
> > [[[
> > Correctly handle non-canonical targets and targets containing peg
> revisions
> > while parsing repository root relative urls.
> >
>

-- 
"Beware of spyware. If you can, use the Firefox browser." - USA Today
Download now at http://getfirefox.com
Registered Linux User #354814 ( http://counter.li.org/)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org