Re: [PATCH] Repository root relative support for the command-line client

On Tue, Apr 29, 2008 at 6:31 AM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> Daniel Shahaf wrote:
>
> > Troy Curtis Jr wrote on Tue, 29 Apr 2008 at 04:49 -0500:
> >
> > > Yep sure enough. My patch can't accept PEG revs on relative url
> > > targets. Doh! I don't have time for a patch right now, I'll do it
> > > later tonight unless someone beats me to it.
> > >
> > >
> >
> > Your patch also seems to require a trailing slash:
> >
> > 0:% ./subversion/svn/svn info '^'
> > subversion/libsvn_client/info.c:266: (apr_err=150000)
> > svn: '^' is not under version control
> > 1:% ./subversion/svn/svn info '^'/ | grep URL
> > URL: https://svn.collab.net/repos/svn
> > 0:%
> > Is this intentional?
> >
>
> cmpilato smells the need for some more unit tests, preferably of the C
> variety. (tests/libsvn_subr/opt-test.c looks like a good place to start)
>
> --
> C. Michael Pilato <cmpilato_at_collab.net>
> CollabNet <> www.collab.net <> Distributed Development On Demand
>
>

I agree, I was actually thinking the same thing. Of course it
wouldn't make sense to put it in libsvn_subr as the option processing
has been moved into libsvn_client by my patch. :) My patch will
definitly include more unit tests!

Troy

-- 
"Beware of spyware. If you can, use the Firefox browser." - USA Today
Download now at http://getfirefox.com
Registered Linux User #354814 ( http://counter.li.org/)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org