epg_at_google.com writes:
>> /* The lock may have become defunct after the commit, so ignore such
>> - errors.
>> -
>> - ### If we ever write a logging facility for svnserve, this
>> - would be a good place to log an error before clearing
>> - it. */
>> - svn_error_clear(svn_repos_fs_unlock(sb->repos, full_path, token,
>> - FALSE, pool));
>> + errors. */
>> + err = svn_repos_fs_unlock(sb->repos, full_path, token,
>> + FALSE, pool);
>> + log_server_error(err, sb, conn, iterpool);
>> + svn_error_clear(err);
>
> Why don't we use iterpool in that svn_repos_fs_unlock call? I
> left it using pool because I wasn't sure.
Looks to me like iterpool would be fine. The code to
svn_repos_fs_unlock() just uses the pool for hook-running and unlocking;
everything stays within the scope of that call, so there shouldn't be
any lifetime issues.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-29 17:34:26 CEST