Re: [PATCH] Repository root relative support for the command-line client

On Mon, Apr 28, 2008 at 3:44 PM, <epg_at_google.com> wrote:
> Julian Foad <julianfoad_at_btopenworld.com> writes:
>
> > Troy,
> >
> > I have reviewed and tested this patch now. The structure is great: thanks for
> >
> > moving things into libsvn_client while maintaining backward compatibility. It
> >
> > works fine. I tweaked a little bit: mainly a doc-string or two, and added
> > localisation macros around the error message strings.
>
> Thanks, guys, awesome feature. It appears to have broken peg
> revisions, though, at least in one case:
>
> 0 trunk5% svn diff ^/trunk_at_30530 ^/branches/svnserve-logging | sed 5q
> Index: Makefile.in
> ===================================================================
> --- Makefile.in (.../trunk) (revision 30814)
> +++ Makefile.in (.../branches/svnserve-logging) (revision 30814)
>

Yep sure enough. My patch can't accept PEG revs on relative url
targets. Doh! I don't have time for a patch right now, I'll do it
later tonight unless someone beats me to it.

Troy

-- 
"Beware of spyware. If you can, use the Firefox browser." - USA Today
Download now at http://getfirefox.com
Registered Linux User #354814 ( http://counter.li.org/)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org